gper/Gnuboard7
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core,board,ecommerce,plugins): API 문서 미채움 마커 전수 채움 + 미해석 lang 키 정정 + IDV 조회 시도횟수 비노출

Browse Source 
이슈 본연: API 레퍼런스의 미채움 마커 5종(실측 제외/TODO/필드 없음/대표 에러 없음)
1,194건을 코드에서 읽어 전수 채우고(0건), api:docgen 재생성이 사람이 채운 내용을
손실·열화시키던 멱등성 결함 4종(CRLF, 표 파이프 이스케이프, 에러 서술 보존, 중복
라우트명 키)을 근본 수정. --check 를 실측 제외와 드리프트가 구분되도록 재정의.
ParameterDescriber/ResourceFieldDescriber 에 leaf 폴백·SEO 스코프·공통 사전 확장.

파생 결함(문서 실측 중 발견): ResponseHelper 기본 메시지 키 6종이 존재하지 않는
messages.* 를 가리켜 응답 message 가 번역문 대신 키 문자열로 노출되던 문제를 common.*
으로 정정하고, 코어 7 + gdpr/marketing/pay_kginicis/verification/ecommerce 확장의
호출부와 누락 lang 키(게시판 10키 + 이커머스 category_images 4키 포함)를 ko/en/ja
전수 정정. 중복 그룹 키 2건은 기존 키로 호출부 통합.

보안: GET /api/identity/challenges/{id} 는 권한 가드 없는 공개 폴링 엔드포인트인데
Service::getStatus 가 attempts/max_attempts 를 응답에 담아 남은 시도 횟수를 추론할 수
있었다. 두 필드를 제거하고, 챌린지 화면(admin_basic/basic)의 서버 attempts 참조를
제거(남은 횟수 UI 는 query fallback + verify 실패 시 로컬 증가로 유지).

부수 정리(변경셋에 들어온 board 컨트롤러의 audit 사전 결함): FormRequest 4개 신설로
base Request 주입 제거, CommentController 의 Board 직접 호출을 BoardService 위임으로
전환, PHPDoc @return 보강. board 스위트에서 발견한 stale test 3건(seed SSoT 불일치,
admin 계정 user 역할 누락)도 같은 세션에서 정정.

버전 정렬(공개 release 기준): 코어 7.0.3→7.0.4, sirsoft-board 1.0.1→1.0.2,
verification_kginicis 1.0.0→1.0.1, admin_basic 1.0.1→1.0.4.
This commit is contained in:
HeuJung committed 2026-08-06 14:16:40 +09:00
1 parent b07d6c8953
commit 6c8381f164
155 files changed
+17192 -1829
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

app/Http/Controllers/Api/Admin/Identity/AdminIdentityLogController.php
+4 -3
View File
@@ -2,6 +2,7 @@
namespace App\Http\Controllers\Api\Admin\Identity;
use App\Enums\PermissionType;
use App\Http\Controllers\Api\Base\AdminBaseController;
use App\Http\Requests\Identity\AdminIdentityLogIndexRequest;
use App\Http\Requests\Identity\AdminIdentityLogPurgeRequest;
@@ -45,7 +46,7 @@ class AdminIdentityLogController extends AdminBaseController
$paginated = $this->logService->search($filters, (int) ($validated['per_page'] ?? 20));
return $this->success('messages.success', [
return $this->success('common.success', [
'data' => IdentityLogResource::collection(collect($paginated->items()))->resolve(),
'pagination' => [
'current_page' => $paginated->currentPage(),
@@ -59,7 +60,7 @@ class AdminIdentityLogController extends AdminBaseController
'abilities' => [
'can_purge' => $request->user()?->hasPermission(
'core.admin.identity.logs.purge',
\App\Enums\PermissionType::Admin,
PermissionType::Admin,
) ?? false,
],
]);
@@ -76,7 +77,7 @@ class AdminIdentityLogController extends AdminBaseController
$days = (int) ($request->validated()['older_than_days'] ?? 180);
$count = $this->logService->purge($days);
return $this->success('messages.success', [
return $this->success('common.success', [
'purged_count' => $count,
'older_than_days' => $days,
]);
app/Http/Controllers/Api/Admin/Identity/AdminIdentityPolicyController.php
+11 -11
View File
@@ -60,7 +60,7 @@ class AdminIdentityPolicyController extends AdminBaseController
$paginated = $this->policyService->search($filters, $perPage);
$collection = (new PolicyCollection($paginated))->toArray($request);
return $this->success('messages.success', [
return $this->success('common.success', [
'data' => $collection['data'],
'abilities' => $collection['abilities'] ?? [],
'meta' => [
@@ -83,7 +83,7 @@ class AdminIdentityPolicyController extends AdminBaseController
$policy = $this->policyService->createAdminPolicy($request->validated());
return $this->success(
'messages.created',
'common.created',
(new PolicyResource($policy))->toArray($request),
201,
);
@@ -101,7 +101,7 @@ class AdminIdentityPolicyController extends AdminBaseController
$policy = $this->policyService->findById($id);
if (! $policy) {
return $this->error('messages.not_found', 404);
return $this->error('common.not_found', 404);
}
$validated = $request->validated();
@@ -119,13 +119,13 @@ class AdminIdentityPolicyController extends AdminBaseController
}
if (! $this->policyService->updatePolicy($policy, $validated)) {
return $this->error('messages.failed', 500);
return $this->error('common.failed', 500);
}
$policy->refresh();
return $this->success(
'messages.updated',
'common.updated',
(new PolicyResource($policy))->toArray($request),
);
}
@@ -142,16 +142,16 @@ class AdminIdentityPolicyController extends AdminBaseController
$policy = $this->policyService->findById($id);
if (! $policy) {
return $this->error('messages.not_found', 404);
return $this->error('common.not_found', 404);
}
if ($policy->source_type !== IdentityPolicySourceType::Admin) {
return $this->forbidden('messages.cannot_delete_system_resource');
return $this->forbidden('identity.errors.cannot_delete_system_policy');
}
return $this->policyService->deleteAdminPolicy($policy)
? $this->success('messages.deleted')
: $this->error('messages.failed', 500);
? $this->success('common.deleted')
: $this->error('common.failed', 500);
}
/**
@@ -170,7 +170,7 @@ class AdminIdentityPolicyController extends AdminBaseController
$policy = $this->policyService->findById($id);
if (! $policy) {
return $this->error('messages.not_found', 404);
return $this->error('common.not_found', 404);
}
if ($policy->source_type === IdentityPolicySourceType::Admin) {
@@ -184,6 +184,6 @@ class AdminIdentityPolicyController extends AdminBaseController
return $this->error('identity.errors.reset_field_failed', 422);
}
return $this->successWithResource('messages.success', new PolicyResource($policy->fresh()));
return $this->successWithResource('common.success', new PolicyResource($policy->fresh()));
}
}
app/Http/Controllers/Api/Admin/Identity/AdminIdentityProviderController.php
+4 -4
View File
@@ -5,9 +5,9 @@ namespace App\Http\Controllers\Api\Admin\Identity;
use App\Extension\HookManager;
use App\Extension\IdentityVerification\IdentityVerificationManager;
use App\Http\Controllers\Api\Base\AdminBaseController;
use App\Http\Requests\Identity\AdminIdentityProviderIndexRequest;
use App\Http\Resources\Identity\ProviderResource;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
/**
* 관리자 — IDV 프로바이더 조회 + 설정 스키마 수집 컨트롤러.
@@ -28,10 +28,10 @@ class AdminIdentityProviderController extends AdminBaseController
/**
* 등록된 프로바이더 목록과 각 프로바이더의 설정 스키마를 반환합니다.
*
* @param Request $request HTTP 요청
* @param AdminIdentityProviderIndexRequest $request 검증된 요청 (파라미터 없음)
* @return JsonResponse 프로바이더 목록 (settings_schema 포함)
*/
public function index(Request $request): JsonResponse
public function index(AdminIdentityProviderIndexRequest $request): JsonResponse
{
$providers = array_values($this->manager->all());
@@ -48,6 +48,6 @@ class AdminIdentityProviderController extends AdminBaseController
return $resource + ['settings_schema' => is_array($schema) ? $schema : []];
}, $providers);
return $this->success('messages.success', $rows);
return $this->success('common.success', $rows);
}
}
app/Http/Controllers/Api/Admin/PluginSettingsController.php
+2 -2
View File
@@ -63,7 +63,7 @@ class PluginSettingsController extends AdminBaseController
return $this->notFound('plugins.not_found');
}
return $this->success('messages.success', $this->maskSensitive($identifier, $settings));
return $this->success('common.success', $this->maskSensitive($identifier, $settings));
}
/**
@@ -109,6 +109,6 @@ class PluginSettingsController extends AdminBaseController
return $this->notFound('plugins.not_found');
}
return $this->success('messages.success', $layout);
return $this->success('common.success', $layout);
}
}
app/Http/Controllers/Api/Admin/SeoCacheController.php
+9 -9
View File
@@ -48,9 +48,9 @@ class SeoCacheController extends AdminBaseController
'by_module' => $this->statsService->getStatsByModule($since),
];
return $this->success('messages.success', $data);
return $this->success('common.success', $data);
} catch (\Exception $e) {
return $this->error('messages.error_occurred', 500, $e->getMessage());
return $this->error('common.error_occurred', 500, $e->getMessage());
}
}
@@ -70,14 +70,14 @@ class SeoCacheController extends AdminBaseController
if ($layout) {
$count = $this->cacheManager->invalidateByLayout($layout);
return $this->success('messages.success', ['cleared' => $count]);
return $this->success('common.success', ['cleared' => $count]);
}
$this->cacheManager->clearAll();
return $this->success('messages.success', ['cleared' => 'all']);
return $this->success('common.success', ['cleared' => 'all']);
} catch (\Exception $e) {
return $this->error('messages.error_occurred', 500, $e->getMessage());
return $this->error('common.error_occurred', 500, $e->getMessage());
}
}
@@ -92,12 +92,12 @@ class SeoCacheController extends AdminBaseController
{
try {
// Phase 5의 SeoDeclarationCollector 구현 후 실제 워밍업 로직 추가 예정
return $this->success('messages.success', [
return $this->success('common.success', [
'status' => 'dispatched',
'message' => __('seo.warmup_dispatched'),
]);
} catch (\Exception $e) {
return $this->error('messages.error_occurred', 500, $e->getMessage());
return $this->error('common.error_occurred', 500, $e->getMessage());
}
}
@@ -149,9 +149,9 @@ class SeoCacheController extends AdminBaseController
try {
$urls = $this->cacheManager->getCachedUrls();
return $this->success('messages.success', ['urls' => $urls, 'count' => count($urls)]);
return $this->success('common.success', ['urls' => $urls, 'count' => count($urls)]);
} catch (\Exception $e) {
return $this->error('messages.error_occurred', 500, $e->getMessage());
return $this->error('common.error_occurred', 500, $e->getMessage());
}
}
}
app/Http/Controllers/Api/Identity/IdentityVerificationController.php
+13 -9
View File
@@ -2,6 +2,7 @@
namespace App\Http\Controllers\Api\Identity;
use App\Enums\IdentityOriginType;
use App\Extension\IdentityVerification\IdentityVerificationManager;
use App\Http\Controllers\Api\Base\PublicBaseController;
use App\Http\Requests\Identity\CancelChallengeRequest;
@@ -15,6 +16,7 @@ use App\Http\Requests\Identity\VerifyChallengeRequest;
use App\Http\Resources\Identity\ChallengeResource;
use App\Http\Resources\Identity\ProviderResource;
use App\Models\IdentityVerificationLog;
use App\Models\User;
use App\Services\IdentityPolicyService;
use App\Services\IdentityVerificationService;
use Illuminate\Http\JsonResponse;
@@ -53,7 +55,7 @@ class IdentityVerificationController extends PublicBaseController
$user = $request->user();
$target = $user ?: ($validated['target'] ?? []);
if (! ($user instanceof \App\Models\User) && empty($target['email']) && empty($target['phone'])) {
if (! ($user instanceof User) && empty($target['email']) && empty($target['phone'])) {
return $this->error('identity.errors.missing_target', 422);
}
@@ -68,7 +70,7 @@ class IdentityVerificationController extends PublicBaseController
context: [
'ip_address' => $request->ip(),
'user_agent' => substr((string) $request->userAgent(), 0, 512),
'origin_type' => \App\Enums\IdentityOriginType::Api->value,
'origin_type' => IdentityOriginType::Api->value,
'origin_identifier' => '/api/identity/challenges',
],
providerId: $providerId,
@@ -136,7 +138,7 @@ class IdentityVerificationController extends PublicBaseController
*
* @param CancelChallengeRequest $request 검증된 요청
* @param IdentityVerificationLog $challenge 라우트 모델 바인딩으로 resolve 된 challenge 로그
* @return JsonResponse
* @return JsonResponse 취소 결과
*/
public function cancel(CancelChallengeRequest $request, IdentityVerificationLog $challenge): JsonResponse
{
@@ -159,7 +161,8 @@ class IdentityVerificationController extends PublicBaseController
*
* @param ShowChallengeRequest $request 검증된 요청
* @param IdentityVerificationLog $challenge 라우트 모델 바인딩으로 resolve 된 challenge 로그
* @return JsonResponse
* @return JsonResponse 공개 안전 상태 필드
*
* @since engine-v1.46.0
*/
public function show(ShowChallengeRequest $request, IdentityVerificationLog $challenge): JsonResponse
@@ -170,7 +173,7 @@ class IdentityVerificationController extends PublicBaseController
return $this->error('identity.errors.challenge_not_found', 404);
}
return $this->success('messages.success', $status);
return $this->success('common.success', $status);
}
/**
@@ -188,6 +191,7 @@ class IdentityVerificationController extends PublicBaseController
* @param IdentityCallbackRequest $request 검증된 요청
* @param string $providerId 콜백을 보낸 provider 식별자
* @return JsonResponse|RedirectResponse
*
* @since engine-v1.46.0
*/
public function callback(IdentityCallbackRequest $request, string $providerId)
@@ -271,7 +275,7 @@ class IdentityVerificationController extends PublicBaseController
$providers,
);
return $this->success('messages.success', $data);
return $this->success('common.success', $data);
}
/**
@@ -300,7 +304,7 @@ class IdentityVerificationController extends PublicBaseController
];
}
return $this->success('messages.success', $data);
return $this->success('common.success', $data);
}
/**
@@ -353,11 +357,11 @@ class IdentityVerificationController extends PublicBaseController
$policy = $this->policyService->resolve($scope, $target);
if (! $policy || ! $policy->enabled) {
return $this->success('messages.success', null);
return $this->success('common.success', null);
}
// 민감 필드는 노출하지 않고 UI 힌트에 필요한 최소 필드만 반환
return $this->success('messages.success', [
return $this->success('common.success', [
'policy_key' => $policy->key,
'scope' => $policy->scope,
'target' => $policy->target,